Remove useless predicates

aleksis/apps/paweljong/predicates.py

@@ -11,31 +11,15 @@ User = get_user_model()
 
 
 @predicate
-def see_group_by_grouptype(user: User, group: Group) -> bool:
-    """Predicate which checks if the user is allowed to see the groups GroupType."""
-    grouptype = group.group_type
-
-    return check_object_permission(user, "core.view_grouptype", grouptype)
-
-
-@predicate
-def see_owned_groups_members(user: User, person: Person) -> bool:
-    """Owners of groups can see their members."""
-    groups_list = user.person.owner_of.all().values_list("id", flat=True)
-
-    return Person.member_of.filter(id__in=groups_list).exists()
-
-
-@predicate
-def is_own_voucher(user: User, voucher: Voucher) -> bool:
+def is_own_voucher(user: User, obj: Voucher) -> bool:
     """Predicate which checks if the voucher belongs to the user."""
-    return voucher.person == user.person
+    return obj.person == user.person
 
 
 @predicate
 def is_own_registration(user: User, registration: EventRegistration) -> bool:
     """Predicate which checks if the registration belongs to the user."""
-    return registration.person == user.person
+    return obj.person == user.person
 
 
 @predicate

aleksis/apps/paweljong/rules.py

@@ -14,8 +14,6 @@ from .predicates import (
     is_own_registration,
     is_own_voucher,
     is_organiser,
-    see_group_by_grouptype,
-    see_owned_groups_members,
 )
 
 # View vouchers
@@ -65,17 +63,6 @@ create_events_predicate = has_person & (
 )
 rules.add_perm("paweljong.create_events_rule", create_events_predicate)
 
-# Allowed to see group
-may_see_group_predicate = has_person & (
-    is_group_member | has_any_object("core.view_group", Group) | see_group_by_grouptype
-)
-rules.add_perm("paweljong.may_see_group_rule", may_see_group_predicate)
-
-may_see_person_predicate = has_person & (
-    see_owned_groups_members | has_object_perm("core.view_person")
-)
-rules.add_perm("paweljong.see_person_rule", may_see_person_predicate)
-
 # Manage registrations
 manage_registrations_predicate = has_person & (
     has_global_perm("paweljong.manage_registration")