Make get_variant_choices callable on the whole dependency chain

aleksis/apps/tezor/models/base.py

@@ -10,6 +10,12 @@ from aleksis.core.mixins import ExtensibleModel
 
 
 class Client(ExtensibleModel):
+    VARIANT_DISPLAY = {
+        "paypal": (_("PayPal"), "logos:paypal"),
+        "sofort": (_("Klarna / Sofort"), "simple-icons:klarna"),
+        "pledge": (_("Payment pledge / manual payment"), "mdi:hand-coin"),
+        "sdd": (_("SEPA Direct Debit"), "mdi:bank-transfer"),
+    }
     name = models.CharField(verbose_name=_("Name"), max_length=255)
     email = models.EmailField(verbose_name=_("Email"))
 
@@ -69,3 +75,11 @@ class Client(ExtensibleModel):
 
     def __str__(self) -> str:
         return self.name
+
+    def get_variant_choices(self=None):
+        choices = []
+        for variant in Client.VARIANT_DISPLAY.keys():
+            if self and not getattr(self, f"{variant}_enabled"):
+                continue
+            choices.append((variant, Client.VARIANT_DISPLAY[variant][0]))
+        return choices

aleksis/apps/tezor/models/invoice.py

@@ -32,6 +32,12 @@ class InvoiceGroup(ExtensibleModel):
     def __str__(self) -> str:
         return self.name
 
+    def get_variant_choices(self=None):
+        if self and self.client:
+            return self.client.get_variant_choices()
+        else:
+            return Client.get_variant_choices()
+
     class Meta:
         constraints = [
             models.UniqueConstraint(fields=["client", "name"], name="group_uniq_per_client")
@@ -39,12 +45,6 @@ class InvoiceGroup(ExtensibleModel):
 
 
 class Invoice(BasePayment, PureDjangoModel):
-    VARIANT_DISPLAY = {
-        "paypal": (_("PayPal"), "logos:paypal"),
-        "sofort": (_("Klarna / Sofort"), "simple-icons:klarna"),
-        "pledge": (_("Payment pledge / manual payment"), "mdi:hand-coin"),
-        "sdd": (_("SEPA Direct Debit"), "mdi:bank-transfer"),
-    }
     STATUS_ICONS = {
         PaymentStatus.WAITING: "mdi:cash-lock-open",
         PaymentStatus.INPUT: "mdi:cash-lock-open",
@@ -105,23 +105,16 @@ class Invoice(BasePayment, PureDjangoModel):
         super().save(*args, **kwargs)
 
     def get_variant_choices(self=None):
-        choices = []
-        for variant in Invoice.VARIANT_DISPLAY.keys():
-            if (
-                self
-                and self.group
-                and self.group.client
-                and not getattr(self.group.client, f"{variant}_enabled")
-            ):
-                continue
-            choices.append((variant, Invoice.VARIANT_DISPLAY[variant][0]))
-        return choices
+        if self and self.group:
+            return self.group.get_variant_choices()
+        else:
+            return InvoiceGroup.get_variant_choices()
 
     def get_variant_name(self):
-        return self.__class__.VARIANT_DISPLAY[self.variant][0]
+        return Client.VARIANT_DISPLAY[self.variant][0]
 
     def get_variant_icon(self):
-        return self.__class__.VARIANT_DISPLAY[self.variant][1]
+        return Client.VARIANT_DISPLAY[self.variant][1]
 
     def get_status_icon(self):
         return self.__class__.STATUS_ICONS[self.status]