Move preferences to model

aleksis/apps/tezor/forms.py

@@ -27,7 +27,17 @@ class InvoicesActionForm(ActionForm):
 class EditClientForm(ExtensibleForm):
     """Form to create or edit clients."""
 
-    layout = Layout("name", "email")
+    layout = Layout(
+        Row("name", "email"),
+        Fieldset(
+            _("Sofort / Klarna"),
+            Row("sofort_api_id", "sofort_api_key", "sofort_project_id"),
+        ),
+        Fieldset(
+            _("PayPal"),
+            Row("paypal_client_id", "paypal_secret", "paypal_capture"),
+        ),
+    )
 
     class Meta:
         model = Client

aleksis/apps/tezor/models/base.py

 from django.db import models
 from django.utils.translation import gettext_lazy as _
 
+from localflavor.generic.models import IBANField, BICField
+
 from aleksis.core.mixins import ExtensibleModel
 
 
@@ -8,9 +10,56 @@ class Client(ExtensibleModel):
     name = models.CharField(verbose_name=_("Name"), max_length=255)
     email = models.EmailField(verbose_name=_("Email"))
 
+    sofort_api_id = models.CharField(verbose_name=_("Sofort / Klarna API ID"), blank=True)
+    sofort_api_key = models.CharField(verbose_name=_("Sofort / Klarna API key"), blank=True)
+    sofort_project_id = models.CharField(verbose_name=_("Sofort / Klarna Project ID"), blank=True)
+
+    paypal_client_id = models.CharField(verbose_name=_("PayPal client ID"), blank=True)
+    paypal_secret = models.CharField(verbose_name=_("PayPal secret"), blank=True)
+    paypal_capture = models.BooleanField(
+        verbose_name=_("Use PayPal Authorize & Capture"), default=False
+    )
+
+    sdd_creditor = models.CharField(verbose_name=_("SEPA Direct Debit - Creditor name"), blank=True)
+    sdd_creditor_identifier = models.CharField(
+        verbose_name=_("SEPA Direct Debit - Creditor identifier"), blank=True
+    )
+    sdd_iban = IBANField(verbose_name=_("IBAN of bank account"), blank=True)
+    sdd_bic = BICField(verbose_name=_("BIC/SWIFT code of bank"), blank=True)
+
     class Meta:
+        sofort_enabled = get_site_preferences("payments__sofort_enabled")
+        paypal_enabled = get_site_preferences("payments__paypal_enabled")
+        debit_enabled = get_site_preferences("payments__debit_enabled")
+
         constraints = [
-            models.UniqueConstraint(fields=["name", "site"], name="uniq_client_per_site")
+            models.UniqueConstraint(fields=["name", "site"], name="uniq_client_per_site"),
+            models.CheckConstraint(
+                check=(
+                    Q(sofort_enabled=True)
+                    & ~Q(sofort_api_id="")
+                    & ~Q(sofort_api_key="")
+                    & ~Q(sofort_project_id="")
+                )
+                | Q(sofort_enabled=False),
+                name="sofort_enabled_configured",
+            ),
+            models.CheckConstraint(
+                check=(
+                    Q(debit_enabled=True)
+                    & ~Q(sdd_creditor="")
+                    & ~Q(sdd_creditor_identifier="")
+                    & ~Q(sdd_iban="")
+                    & ~Q(sdd_bic="")
+                )
+                | Q(debit_enabled=False),
+                name="debit_enabled_configured",
+            ),
+            models.CheckConstraint(
+                check=(Q(paypal_enabled=True) & ~Q(paypal_client_id="") & ~Q(paypal_secret=""))
+                | Q(paypal_enabled=False),
+                name="paypal_enabled_configured",
+            ),
         ]
 
     def __str__(self) -> str:

aleksis/apps/tezor/preferences.py

@@ -24,99 +24,41 @@ class PublicPayments(BooleanPreference):
 
 
 @site_preferences_registry.register
-class SofortAPIID(StringPreference):
-    """Sofort payment backend - API ID."""
-
-    section = payments
-    name = "sofort_api_id"
-    verbose_name = _("Sofort / Klarna - API ID")
-    default = ""
-    required = False
-
-
-@site_preferences_registry.register
-class SofortAPIKey(StringPreference):
-    """Sofort payment backend - API key."""
-
-    section = payments
-    name = "sofort_api_key"
-    verbose_name = _("Sofort / Klarna - API Key")
-    default = ""
-    required = False
-
-
-@site_preferences_registry.register
-class SofortProjectID(StringPreference):
-    """Sofort payment backend - project ID."""
-
-    section = payments
-    name = "sofort_project_id"
-    verbose_name = _("Sofort / Klarna - Project ID")
-    default = ""
-    required = False
-
-
-@site_preferences_registry.register
-class PaypalClientID(StringPreference):
-    """PayPal payment backend - client ID."""
-
-    section = payments
-    name = "paypal_client_id"
-    verbose_name = _("PayPal - Client ID")
-    default = ""
-    required = False
-
-
-@site_preferences_registry.register
-class PaypalSecret(StringPreference):
-    """PayPal payment backend - secret."""
-
-    section = payments
-    name = "paypal_secret"
-    verbose_name = _("PayPal - Secret")
-    default = ""
-    required = False
-
-
-@site_preferences_registry.register
-class PaypalCapture(BooleanPreference):
-    """PayPal payment backend - use Authorize & Capture."""
+class EnablePledge(BooleanPreference):
+    """Payment pledge payment backend - enable or not."""
 
     section = payments
-    name = "paypal_capture"
-    verbose_name = _("PayPal - Use Authorize & Capture")
+    name = "pledge_enabled"
+    verbose_name = _("Enable pledged payments")
     default = False
     required = False
 
-
 @site_preferences_registry.register
-class EnablePledge(BooleanPreference):
-    """Payment pledge payment backend - enable or not."""
+class EnablePayPal(BooleanPreference):
+    """Payment paypal payment backend - enable or not."""
 
     section = payments
-    name = "pledge_enabled"
-    verbose_name = _("Enable pledged payments")
+    name = "paypal_enabled"
+    verbose_name = _("Enable PayPal payments")
     default = False
     required = False
 
-
 @site_preferences_registry.register
-class SDDCreditor(StringPreference):
-    """SEPA direct debit backend - creditor name."""
+class EnableSofort(BooleanPreference):
+    """Payment sofort payment backend - enable or not."""
 
     section = payments
-    name = "sdd_creditor"
-    verbose_name = _("SEPA Direct Debit - Creditor name")
-    default = ""
+    name = "sofort_enabled"
+    verbose_name = _("Enable Sofort payments")
+    default = False
     required = False
 
-
 @site_preferences_registry.register
-class SDDCreditorIdentifier(StringPreference):
-    """SEPA direct debit backend - creditor identifier."""
+class EnableDebit(BooleanPreference):
+    """Payment debit payment backend - enable or not."""
 
     section = payments
-    name = "sdd_creditor_identifier"
-    verbose_name = _("SEPA Direct Debit - Creditor identifier")
-    default = ""
+    name = "sdd_enabled"
+    verbose_name = _("Enable debit payments")
+    default = False
     required = False