Move payment variant icon/name lookup to model

aleksis/apps/tezor/models/invoice.py

@@ -33,6 +33,13 @@ class InvoiceGroup(ExtensibleModel):
 
 
 class Invoice(BasePayment, PureDjangoModel):
+    VARIANT_DISPLAY = {
+        "paypal": (_("PayPal"), "logos:paypal"),
+        "sofort": (_("Klarna / Sofort"), "simple-icons:klarna"),
+        "pledge": (_("Payment pledge / manual payment"), "mdi:hand-coin"),
+        "sdd": (_("SEPA Direct Debit"), "mdi:bank-transfer"),
+    }
+
     group = models.ForeignKey(
         InvoiceGroup, verbose_name=_("Invoice group"), related_name="invoices", on_delete=models.SET_NULL, null=True
     )
@@ -43,6 +50,12 @@ class Invoice(BasePayment, PureDjangoModel):
     for_object_id = models.PositiveIntegerField()
     for_object = GenericForeignKey("for_content_type", "for_object_id")
 
+    def get_variant_name(self):
+        return self.__class__.VARIANT_DISPLAY[self.variant][0]
+
+    def get_variant_icon(self):
+        return self.__class__.VARIANT_DISPLAY[self.variant][1]
+
     def get_purchased_items(self):
         return self.for_object.get_purchased_items()
 

aleksis/apps/tezor/templates/tezor/invoice/full.html

@@ -64,14 +64,10 @@
             <table class="highlight">
               <tr>
                 <td>
-                  {% if object.variant == "paypal" %}
-                  <i class="material-icons iconify" data-icon="logos:paypal"></i>
-                  {% elif object.variant == "sofort" %}
-                  <i class="material-icons iconify" data-icon="simple-icons:klarna"></i>
-                  {% endif %}
+                  <i class="material-icons iconify" data-icon="{{ object.get_variant_icon }}"></i>
                 </td>
                 <td>
-                  {{ object.variant }}
+                  {{ object.get_variant_name }}
                 </td>
               </tr>
               <tr>