Skip to content
Snippets Groups Projects
Commit f8fb7c07 authored by Jonathan Weth's avatar Jonathan Weth :keyboard:
Browse files

Merge branch '65-adapt-to-managed_by-change' into 'master'

Resolve "Adapt to managed_by change"

Closes #65

See merge request !86
parents 90605579 a86f8892
No related branches found
No related tags found
1 merge request!86Resolve "Adapt to managed_by change"
Pipeline #196554 failed
...@@ -480,7 +480,8 @@ class LessonBundle(ExtensibleModel): ...@@ -480,7 +480,8 @@ class LessonBundle(ExtensibleModel):
) )
lesson_bundle.lessons.set( lesson_bundle.lessons.set(
[Lesson.create_from_course(course, validity_range) for course in course_bundle.courses.all()] [Lesson.create_from_course(course, validity_range)
for course in course_bundle.courses.all()]
) )
return lesson_bundle return lesson_bundle
...@@ -552,7 +553,7 @@ class Lesson(TeacherPropertiesMixin, RoomPropertiesMixin, ExtensibleModel): ...@@ -552,7 +553,7 @@ class Lesson(TeacherPropertiesMixin, RoomPropertiesMixin, ExtensibleModel):
def create_from_course(cls, course: Course, validity_range: ValidityRange) -> "Lesson": def create_from_course(cls, course: Course, validity_range: ValidityRange) -> "Lesson":
"""Create a lesson from a course backed by a validity range.""" """Create a lesson from a course backed by a validity range."""
# Lookup the TCC for the course in the validity_range # Lookup the TCC for the course in the validity_range
tcc = TimeboundCourseConfig.objects.managed_and_unmanaged().get( tcc = TimeboundCourseConfig.objects.get(
course=course, validity_range=validity_range course=course, validity_range=validity_range
) )
lesson = cls.objects.create( lesson = cls.objects.create(
......
...@@ -33,9 +33,6 @@ class GroupTypeCourseGroups(ModelChoicePreference): ...@@ -33,9 +33,6 @@ class GroupTypeCourseGroups(ModelChoicePreference):
verbose_name = _("Group type for automatically created course groups") verbose_name = _("Group type for automatically created course groups")
help_text = _("If you leave it empty, no group type will be used.") help_text = _("If you leave it empty, no group type will be used.")
def get_queryset(self):
return GroupType.objects.managed_and_unmanaged()
@site_preferences_registry.register @site_preferences_registry.register
class FillCourseGroupsWithMembers(BooleanPreference): class FillCourseGroupsWithMembers(BooleanPreference):
......
...@@ -249,7 +249,7 @@ class Query(graphene.ObjectType): ...@@ -249,7 +249,7 @@ class Query(graphene.ObjectType):
return [] return []
return graphene_django_optimizer.query( return graphene_django_optimizer.query(
CourseBundle.objects.managed_and_unmanaged() CourseBundle.objects
.filter(Q(courses__groups__id=group) | Q(courses__groups__parent_groups__id=group)) .filter(Q(courses__groups__id=group) | Q(courses__groups__parent_groups__id=group))
.distinct() .distinct()
.annotate(validity_range_id=Value(validity_range)), .annotate(validity_range_id=Value(validity_range)),
......
...@@ -16,7 +16,7 @@ class TimeboundCourseType(BaseCourseType): ...@@ -16,7 +16,7 @@ class TimeboundCourseType(BaseCourseType):
def resolve_lesson_quota(root, info): def resolve_lesson_quota(root, info):
"""Resolve lesson_quota from timebound_course_config""" """Resolve lesson_quota from timebound_course_config"""
return ( return (
TimeboundCourseConfig.objects.managed_and_unmanaged() TimeboundCourseConfig.objects
.get( .get(
course=root, course=root,
validity_range__id=root.validity_range_id, validity_range__id=root.validity_range_id,
...@@ -27,7 +27,7 @@ class TimeboundCourseType(BaseCourseType): ...@@ -27,7 +27,7 @@ class TimeboundCourseType(BaseCourseType):
def resolve_teachers(root, info): def resolve_teachers(root, info):
"""Resolve teachers from timebound_course_config""" """Resolve teachers from timebound_course_config"""
return ( return (
TimeboundCourseConfig.objects.managed_and_unmanaged() TimeboundCourseConfig.objects
.get(course=root, validity_range__id=root.validity_range_id) .get(course=root, validity_range__id=root.validity_range_id)
.teachers.all() .teachers.all()
) )
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment