[Reformat] Fix names of functions and variables

aleksis/apps/untis/apps.py

@@ -9,7 +9,7 @@ class UntisConfig(AppConfig):
         "Repository": "https://edugit.org/AlekSIS/official/AlekSIS-App-Untis/",
     }
     licence = "EUPL-1.2+"
-    copyright = (
+    copyright_info = (
         ([2018, 2019, 2020], "Jonathan Weth", "wethjo@katharineum.de"),
         ([2018, 2019], "Frank Poetzsch-Heffter", "p-h@katharineum.de"),
         ([2019, 2020], "Dominik George", "dominik.george@teckids.org"),

aleksis/apps/untis/util/mysql/importers/substitutions.py

@@ -128,8 +128,8 @@ def import_substitutions(
             classes = []
             class_ids = untis_split_first(sub.classids, conv=int)
 
-            for id in class_ids:
-                classes.append(classes_ref[id])
+            for id_ in class_ids:
+                classes.append(classes_ref[id_])
 
             if lesson_period:
                 (substitution, created,) = chronos_models.LessonSubstitution.objects.get_or_create(

aleksis/apps/untis/util/xml/xml.py

 from datetime import date, time, timedelta
 from typing import BinaryIO, Optional, Union
-from xml.dom import Node, minidom
+from xml.dom import Node
 
 from django.http import HttpRequest
 from django.utils.translation import ugettext as _
 
+import defusedxml
+
 from aleksis.apps.chronos.models import Lesson, Room, Subject, TimePeriod
 from aleksis.core.models import Group, Person
 from aleksis.core.util import messages
@@ -29,7 +31,7 @@ def get_child_node_id(node: Node, tag: str) -> Optional[str]:
 
 
 def untis_import_xml(request: HttpRequest, untis_xml: Union[BinaryIO, str]) -> None:
-    dom = minidom.parse(untis_xml)
+    dom = defusedxml.parse(untis_xml)
 
     subjects = dom.getElementsByTagName("subject")
     for subject_node in subjects:

pyproject.toml

@@ -24,6 +24,7 @@ AlekSIS = { path = "../../.." }
 AlekSIS-App-Chronos = { path = "../AlekSIS-App-Chronos" }
 mysqlclient = "^1.4.6"
 tqdm = "^4.44.1"
+defusedxml = "^0.6.0"
 
 [build-system]
 requires = ["poetry>=0.12"]