Merge branch '57-importing-exams-broken-due-to-missing-time-period' into 'master'

Resolve "Importing exams broken due to missing time period"

Closes #57

See merge request !159

CHANGELOG.rst

@@ -13,6 +13,7 @@ Fixed
 ~~~~~
 
 * Importer failed sometimes on progressing absences.
+* Exam import failed sometimes when data provided through Untis were incomplete.
 
 `2.3.2`_ - 2022-09-01
 ---------------------

aleksis/apps/untis/util/mysql/importers/exams.py

@@ -50,8 +50,8 @@ def import_exams(
         logger.info("Import exam {}".format(import_ref))
 
         # Build values
-        title = exam.name
-        comment = exam.text
+        title = exam.name or ""
+        comment = exam.text or ""
 
         day = untis_date_to_date(exam.date)
         period_from = exam.lessonfrom
@@ -90,6 +90,9 @@ def import_exams(
                 subject = subjects_ref[subject_id]
             first = False
             period = int(el[4])
+            if not period:
+                logger.warning("  Skip incomplete exam element")
+                continue
             period = time_periods_ref[weekday][period]
             teacher_id = int(el[5])
             room_id = int(el[6])
@@ -97,8 +100,8 @@ def import_exams(
             room = rooms_ref[room_id]
             exams.append((period, teacher, room))
 
-        if not lesson or not subject:
-            logger.warning(f"Skip exam {import_ref} due to missing data.")
+        if not lesson or not subject or not exams:
+            logger.warning("  Skip exam due to missing data.")
             continue
 
         new_exam, created = chronos_models.Exam.objects.update_or_create(
@@ -162,5 +165,5 @@ def import_exams(
             validity_range.date_start, validity_range.date_end
         ):
             if e.import_ref_untis and e.import_ref_untis not in existing_exams:
-                logger.info("exam {} deleted".format(e.id))
+                logger.info(f"  Exam {e.id} deleted")
                 e.delete()