Skip to content
Snippets Groups Projects
Verified Commit 83c085b6 authored by Jonathan Weth's avatar Jonathan Weth :keyboard:
Browse files

Rename get_from_period to from_period and add docstring

parent 4fe76e99
No related branches found
No related tags found
1 merge request!129Rewrite some API on Event and ExtraLesson
Pipeline #5903 passed
...@@ -218,7 +218,11 @@ class TimePeriod(ValidityRangeRelatedExtensibleModel): ...@@ -218,7 +218,11 @@ class TimePeriod(ValidityRangeRelatedExtensibleModel):
return url_prev, url_next return url_prev, url_next
@classmethod @classmethod
def get_from_period(cls, period: int, day: date) -> "TimePeriod": def from_period(cls, period: int, day: date) -> "TimePeriod":
"""Get `TimePeriod` object for a period on a specific date.
This will respect the relation to validity ranges.
"""
return cls.objects.on_day(day).filter(period=period).first() return cls.objects.on_day(day).filter(period=period).first()
@classproperty @classproperty
...@@ -907,7 +911,7 @@ class Event(SchoolTermRelatedExtensibleModel, GroupPropertiesMixin, TeacherPrope ...@@ -907,7 +911,7 @@ class Event(SchoolTermRelatedExtensibleModel, GroupPropertiesMixin, TeacherPrope
""" """
day = getattr(self, "_date", timezone.now().date()) day = getattr(self, "_date", timezone.now().date())
if day != self.date_start: if day != self.date_start:
return TimePeriod.get_from_period(TimePeriod.period_min, day) return TimePeriod.from_period(TimePeriod.period_min, day)
else: else:
return self.period_from return self.period_from
...@@ -919,7 +923,7 @@ class Event(SchoolTermRelatedExtensibleModel, GroupPropertiesMixin, TeacherPrope ...@@ -919,7 +923,7 @@ class Event(SchoolTermRelatedExtensibleModel, GroupPropertiesMixin, TeacherPrope
""" """
day = getattr(self, "_date", timezone.now().date()) day = getattr(self, "_date", timezone.now().date())
if day != self.date_end: if day != self.date_end:
return TimePeriod.get_from_period(TimePeriod.period_max, day) return TimePeriod.from_period(TimePeriod.period_max, day)
else: else:
return self.period_to return self.period_to
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment