From ff616aab4e4b57a9b419ca759056896f44e3ea5c Mon Sep 17 00:00:00 2001
From: Hangzhi Yu <hangzhi@protonmail.com>
Date: Sun, 26 Feb 2023 17:36:02 +0100
Subject: [PATCH] Fix redirect error of seating plan edit forms
---
CHANGELOG.rst | 5 +++++
aleksis/apps/stoelindeling/views.py | 8 ++++----
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 58be4f5..16113a4 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -22,6 +22,11 @@ Added
* Support for usage with new AlekSIS SPA.
+Fixed
+~~~~~
+
+* In some cases, seating plan edit forms caused an error when trying to redirect after they were filled successfully.
+
`1.0.2`_ - 2022-11-04
---------------------
diff --git a/aleksis/apps/stoelindeling/views.py b/aleksis/apps/stoelindeling/views.py
index 72ac168..f1367e9 100644
--- a/aleksis/apps/stoelindeling/views.py
+++ b/aleksis/apps/stoelindeling/views.py
@@ -48,7 +48,7 @@ class SeatingPlanDetailView(PermissionRequiredMixin, DetailView):
@method_decorator(never_cache, name="dispatch")
-class SeatingPlanCreateView(PermissionRequiredMixin, SuccessNextMixin, AdvancedCreateView):
+class SeatingPlanCreateView(PermissionRequiredMixin, AdvancedCreateView):
"""Create view for seating plans."""
model = SeatingPlan
@@ -138,7 +138,7 @@ class SeatingPlanEditView(PermissionRequiredMixin, SuccessNextMixin, AdvancedEdi
@method_decorator(never_cache, name="dispatch")
-class SeatingPlanCopyView(PermissionRequiredMixin, SuccessNextMixin, AdvancedEditView):
+class SeatingPlanCopyView(PermissionRequiredMixin, AdvancedEditView):
"""Copy view for seating plans."""
model = SeatingPlan
@@ -147,7 +147,7 @@ class SeatingPlanCopyView(PermissionRequiredMixin, SuccessNextMixin, AdvancedEdi
template_name = "stoelindeling/seating_plan/copy.html"
def get_success_url(self):
- return reverse("edit_seating_plan", args=[self.new_object.pk]) # FiXME NEXT URL
+ return reverse("edit_seating_plan", args=[self.new_object.pk])
def get_form_kwargs(self):
kwargs = super().get_form_kwargs()
@@ -176,7 +176,7 @@ class SeatingPlanCopyView(PermissionRequiredMixin, SuccessNextMixin, AdvancedEdi
@method_decorator(never_cache, name="dispatch")
class SeatingPlanDeleteView(
- PermissionRequiredMixin, RevisionMixin, SuccessNextMixin, AdvancedDeleteView
+ PermissionRequiredMixin, RevisionMixin, AdvancedDeleteView
):
"""Delete view for seating plans."""
--
GitLab